sammccall added inline comments.

================
Comment at: clang/lib/AST/DeclPrinter.cpp:1010
 
+  if (D->isEffectivelyFinal()) {
+      Out << " final";
----------------
isEffectivelyFinal returns true for
`struct X { ~X() final; }`

I don't think we want to print `struct X final {}` in that case.

Probably want to replicate the check for FinalAttr instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128202/new/

https://reviews.llvm.org/D128202

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to