sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:192 + continue; + // Deletion range initially spans the initializer, excluding the `=`. + auto DelRange = CharSourceRange::getTokenRange(PVD->getDefaultArgRange()); ---------------- nit: usually excluding the `=` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128197/new/ https://reviews.llvm.org/D128197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits