whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land.
Thank you! ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:170 + <clang-tidy/checks/cppcoreguidelines-virtual-class-destructor>` involving + ``final`` classes. The check will not diagnose ``final`` marked classes, since + those cannot be used as base classes, consequently they can not violate the ---------------- (Nit: classes marked final) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126891/new/ https://reviews.llvm.org/D126891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits