ABataev added inline comments.

================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5035-5039
+    llvm::APInt TrueOrFalse(32,
+                            S.hasClausesOfKind<OMPInReductionClause>() ? 0 : 
1);
+    IntegerLiteral IfCond(getContext(), TrueOrFalse,
+                          getContext().getIntTypeForBitwidth(32, /*Signed=*/0),
+                          SourceLocation());
----------------
Why integer, not a boolean? Also, this is currently meaningless, since these 2 
vars are not visible outside of the if context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125669/new/

https://reviews.llvm.org/D125669

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to