rjmccall added a comment. Minor suggestion for a cleanup, then LGTM.
================ Comment at: clang/lib/Sema/SemaOverload.cpp:9048 + ParamTypes[0] = S.Context.getVolatileType(ParamTypes[0]); + ParamTypes[0] = S.Context.getLValueReferenceType(ParamTypes[0]); + S.AddBuiltinCandidate(ParamTypes, Args, CandidateSet); ---------------- Can you add a helper function to build this qualified l-value reference type from a `QualifiersAndAtomic`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits