hctim added inline comments.

================
Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:101
+      llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
+          llvm::Type::getInt1Ty(VMContext), Meta.IsDynInit)),
       llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(
----------------
vitalybuka wrote:
> Meta.IsDynInit -> IsDynInit
> they must be equal, and this legacy code better not use new Meta.
sure. in practice, `Meta.IsDynInit` is exactly equal to `IsDynInit`, but moved 
it back for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126929/new/

https://reviews.llvm.org/D126929

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to