hans added a comment. > Previously, /FAsc would emit a warning. Now, it will just do what /FA does.
I suppose we could still warn that the 's' and 'c' parts are ignored.. though I suppose that becomes evident from the output file.. If we're going to treat them the same, how about just making the _SLASH_FA option a CLJoined and dropping _SLASH_FA_joined? > I'm not sure which test file to modify and how to test this. I do see it > generating the .asm file now when I pass /FAsc, not the .codd file though > since we are ignoring the c argument. There are some /FA tests in clang/test/Driver/cl-options.c and clang/test/Driver/cl-outputs.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127519/new/ https://reviews.llvm.org/D127519 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits