ahatanak added inline comments.
================
Comment at: include/clang/Basic/TargetInfo.h:585
@@ +584,3 @@
+ StringRef
+ TargetInfo::getNormalizedGCCRegisterName(StringRef Name,
+ bool ReturnCannonical = false)
const;
----------------
This gives build errors. TargetInfo:: isn't needed here.
================
Comment at: lib/Headers/Intrin.h:843
@@ -842,4 +842,3 @@
__movsb(unsigned char *__dst, unsigned char const *__src, size_t __n) {
- __asm__("rep movsb" : : "D"(__dst), "S"(__src), "c"(__n)
- : "%edi", "%esi", "%ecx");
+ __asm__("rep movsb" : : "D"(__dst), "S"(__src), "c"(__n) :);
}
----------------
If this is an unrelated bug that you discovered while working on this patch,
you should probably send a separate patch to the list and contact the author.
================
Comment at: lib/Sema/SemaStmtAsm.cpp:179
@@ +178,3 @@
+ case 'a':
+ return "ax";
+ case 'b':
----------------
I don't think things specific to x86 should appear in SemaStmtAsm.cpp. Also, is
it possible to use X86TargetInfo::convertConstraint?
http://reviews.llvm.org/D15075
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
