c-rhodes accepted this revision.
c-rhodes added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:13591-13595
+ if (!Target->isVLSTBuiltinType() && !isa<VectorType>(OriginalTarget)) {
+ if (S.SourceMgr.isInSystemMacro(CC))
+ return;
+ return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
+ }
----------------
DavidTruby wrote:
> c-rhodes wrote:
> > can a test be added for this?
> It appears this code doesn't actually do anything as this condition is
> covered elsewhere (and tested below) so I've just removed it
> It appears this code doesn't actually do anything as this condition is
> covered elsewhere (and tested below) so I've just removed it
Great! Thanks for investigating, can this code also be removed from the generic
vector version this was copied from then? Just curious I won't let that hold up
this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126380/new/
https://reviews.llvm.org/D126380
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
