tbaeder added a comment. In D127310#3568777 <https://reviews.llvm.org/D127310#3568777>, @nemanjai wrote:
> In D127310#3567472 <https://reviews.llvm.org/D127310#3567472>, @MaskRay wrote: > >> Do you have more authoritative answer when /root/usr is used and when it >> isn't? > > These suffixes were always part of the code and the mentioned changeset > removed it without any justification. The burden of providing this answer > should lie with the author of the change that removed this (i.e. @tbaeder). > Here at IBM, we are not aware of any Redhat release that does not have this > suffix. Namely, all of our RH PowerPC machines with all the toolset versions > and distro versions we have available have the suffix. So we are ill equipped > to answer this question. I assume that Timm is aware of situations where this > isn't part of the path. I did not remove that on purpose, so adding it back makes sense to me. >> This change also needs a unit test. > > +1 Does the existing unit test not break with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
