aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM, thank you! ================ Comment at: clang/test/Sema/large-bit-int.c:1 +// RUN: %clang_cc1 -fexperimental-max-bitint-width=1024 -fsyntax-only -verify %s -Wno-unused -triple x86_64-gnu-linux + ---------------- mgehre-amd wrote: > aaron.ballman wrote: > > Thoughts on adding a frontend diagnostic if the user specifies a value > > larger than `llvm::IntegerType::MAX_INT_BITS`? I'm on the fence. OTOneH, > > this gives a good user experience in the event of mistypes in the command > > line, OTOtherH, it's a cc1-only option that we expect to remove in the > > (hopefully) near future. > > > > Also, I don't think the triple is needed and I'm pretty sure `-Wno-unused` > > is the default already. > I was thinking that this is both only a cc1 option and at the same time > MAX_INT_BITS is really big, so I don't imagine a practical case where one > intends to have bigger _BitInts. Perfect, I'm sold. We can always add a diagnostic later if we find users actually run up against this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127287/new/ https://reviews.llvm.org/D127287 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
