ChuanqiXu added a comment. In D113545#3562658 <https://reviews.llvm.org/D113545#3562658>, @iains wrote:
> Did you try wider testing (e.g. with lldb and other parts of the toolchain?) Yeah, I tried some other testing including using modules slightly in SPEC2017 and some other C++ performance benchmarks to make sure the introduction of C++ modules wouldn't cause performance regression. But testing is never enough : ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
