hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/pseudo/gen/BUILD.gn:1
-executable("pseudo-gen") {
+executable("clang-pseudo-gen") {
configs += [ "//llvm/utils/gn/build:clang_code" ]
----------------
I was skeptical there should be an additional change in the gn build (building
the inc file), but it looks like the gn file is incomplete, the `cxx` doesn't
compile in gn build, there is a
[fixme](https://github.com/llvm/llvm-project/blob/main/llvm/utils/gn/secondary/clang-tools-extra/pseudo/cxx/BUILD.gn#L2),
I think it is ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126725/new/
https://reviews.llvm.org/D126725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
