HazardyKnusperkeks added a comment.

In D126132#3533033 <https://reviews.llvm.org/D126132#3533033>, @owenpan wrote:

> @HazardyKnusperkeks I think you know this better than any of us as you added 
> the assertion to `setType()`. Does this look ok to you?

This looks good.
One should define what is the difference between `TT_LambdaArrow` and 
`TT_TrailingReturnArrow`. But if there is a difference, then the lambda arrows 
should stay `TT_LambdaArrow`, right?

In D126132#3531643 <https://reviews.llvm.org/D126132#3531643>, @MyDeveloperDay 
wrote:

> LGTM  (sorry I've been slow on the reviews, my day job keeps getting in the 
> way ;-))

Same here, I'm just starting to catch up the last weeks. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126132/new/

https://reviews.llvm.org/D126132

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to