python3kgae marked 3 inline comments as done. python3kgae added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:11721 + Diag(FD->getLocation(), diag::err_hlsl_missing_numthreads) << "Compute"; + FD->setInvalidDecl(); + } ---------------- bruno wrote: > Since this is both checking and invalidating a decl, perhaps it should return > a bool (maybe some asserts in the default case?) and be renamed > `CheckAndInvalidateHLSLEntryPoint`? The name is following CheckMain and CheckMSVCRTEntryPoint which also checking and invalidating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
