python3kgae marked 3 inline comments as done.
python3kgae added inline comments.
================
Comment at: clang/test/CodeGenHLSL/entry.hlsl:1
+// RUN: %clang --driver-mode=dxc -Tcs_6_1 -Efoo -fcgl -Fo - %s | FileCheck %s
+
----------------
Anastasia wrote:
> Is this test here accidental?
This test is to make sure generate "dx.shader" attribute on entry function
which set by -E option.
================
Comment at: clang/test/CodeGenHLSL/shader_type_attr.hlsl:3
+
+// Make sure not mangle entry.
+// CHECK:define void @foo()
----------------
Anastasia wrote:
> I struggle understand the difference in this test? Can it be merged with the
> above?
The difference between these 2 tests is entry.hlsl test for entry which does
not have shader attribute on foo while shader_type_attr.hlsl test for entry in
a library which has shader attribute (the [shader("compute")]).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124752/new/
https://reviews.llvm.org/D124752
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
