ymandel marked 3 inline comments as done.
ymandel added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:407
for (const FieldDecl *Field : getAccessibleObjectFields(Type)) {
assert(Field != nullptr);
----------------
sgatev wrote:
> Why not use `getObjectFields` here too?
We could. I figured it was still worth the optimization on the values. Usually,
its correct and otherwise we lose some precision. But, now that you asked, I'm
inclined to get rid of it altogether -- seems like we should have evidence of
the benefit in practice before adopt an approach that we know costs us
precision (in potentially surprising ways).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126420/new/
https://reviews.llvm.org/D126420
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
