python3kgae added inline comments.
================
Comment at: clang/lib/Basic/LangOptions.cpp:122
+ if (Opts.HLSL)
+ Includes.push_back("hlsl.h");
----------------
Anastasia wrote:
> Is this header expected to be large? You might want to flag up in the
> description of the review and the comments in the header itself what content
> is expected to be there.
>
> If the file is expected to be large it might make sense to add a flag that
> would disable this include. You can then for example use bare clang without
> this header for all the tests that don't require functionality from the
> header to reduce the testing time.
It might be large when more things are added.
I'll add an option to disable the include.
================
Comment at: clang/test/CodeGenHLSL/basic_types.hlsl:1
+// RUN: %clang_dxc -Tlib_6_7 -Fo - %s | FileCheck %s
+
----------------
Anastasia wrote:
> Technically mapping into IR types might be target specific, so passing the
> triple is necessary for this test to work correctly. Alternatively you can
> switch to AST dump checking, however even that might be target specific in
> some cases.
The option -T lib_6_7 decides the triple.
"-Tlib_6_7 -Fo -" will be translated into
"-cc1" "-triple" "dxil--shadermodel6.7-library" "-o" "-" "-x" "hlsl" for cc1.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125052/new/
https://reviews.llvm.org/D125052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
