wanders added a comment.

This looks sensible to me. But I'm not an expert in the area (and still not 
100% clear on the purpose of the ignorelist) so can't really say if the added 
comments captures the intent accurately.



================
Comment at: clang/test/Driver/embed-bitcode-elf.c:1
+// RUN: %clang -c -target aarch64-linux-android21 %s -fembed-bitcode -o %t.o \
+// RUN: -ffunction-sections -fdata-sections -fstack-protector-strong
----------------
Should this test have a `// REQUIRES: aarch64-registered-target`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125974/new/

https://reviews.llvm.org/D125974

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to