NoQ added a comment.
Looks awesome!
> add_new_check.py
I'm surprised it wasn't executable already, do we want to keep it?
================
Comment at: clang-tools-extra/clang-tidy/objc/CMakeLists.txt:13
NSInvocationArgumentLifetimeCheck.cpp
+ NsdateformatterCheck.cpp
ObjCTidyModule.cpp
----------------
Looks like everybody's respecting CaPiTaLiZaTiOn, I guess we could too?
================
Comment at: clang-tools-extra/clang-tidy/objc/NsdateformatterCheck.cpp:22
+ // Adding matchers.
+ Finder->addMatcher(objcMessageExpr(hasSelector("setDateFormat:"),
hasArgument(0, hasDescendant( stringLiteral().bind("str_lit")))), this);
+}
----------------
Please clang-format this down to 80 column limit
(https://llvm.org/docs/CodingStandards.html).
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:87
`bugprone-reserved-identifier <bugprone-reserved-identifier.html>`_, "Yes"
- `bugprone-shared-ptr-array-mismatch
<bugprone-shared-ptr-array-mismatch.html>`_, "Yes"
`bugprone-signal-handler <bugprone-signal-handler.html>`_,
----------------
Where did these go?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126097/new/
https://reviews.llvm.org/D126097
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
