LegalizeAdulthood added inline comments.
================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:180 + the ``CheckHeaderFile=true`` option if header files of the project only + included by c++ source files. ---------------- Capitalize to `C++` ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-deprecated-headers-extern-c.cpp:2-4 // Copy the 'mylib.h' to a directory under the build directory. This is // required, since the relative order of the emitted diagnostics depends on the // absolute file paths which is sorted by clang-tidy prior emitting. ---------------- steakhal wrote: > LegalizeAdulthood wrote: > > IMO, all of this hackery is simply ducking the issue, which is that > > `check_clang_tidy.py` doesn't have proper support for validating fixits > > applied to header files. > > > > See https://reviews.llvm.org/D17482 > I agree that this is nasty, but this was the only way I found to still test > the feature I'm about to introduce. Agreed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125769/new/ https://reviews.llvm.org/D125769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
