curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

Thanks for the patch!
Could you please add a unit test in unittest/Format/FormatTest.cpp instead of 
in lit-based test/?
Is there a bug report that your patch fixes?



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1228
       bool IsMark = CurrentToken->is(Keywords.kw_mark);
       next(); // Consume "mark".
       next(); // Consume first token (so we fix leading whitespace).
----------------
Please fix (remove) this comment that consumes not only mark.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125961/new/

https://reviews.llvm.org/D125961

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to