nikic added inline comments.

================
Comment at: llvm/include/llvm/LTO/Config.h:182
+  /// unless already set by the `-opaque-pointers` commandline option.
+  bool OpaquePointers = false;
+
----------------
The default should be true here and for the LLD/LLVMgold flags, to match the 
Clang default and upcoming LLVM default. It's also the conservative option, 
because `OpaquePointers=true` will work fine with typed bitcode, but not the 
other way around. As this change disables the auto-detection, leaving the 
default to off would be a big footgun for anyone invoking LTO through the 
linker rather than the clang driver.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125847/new/

https://reviews.llvm.org/D125847

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to