ChuanqiXu added a comment. In D125291#3523818 <https://reviews.llvm.org/D125291#3523818>, @efriedma wrote:
> I don't really understand how this is supposed to interact with D125292 > <https://reviews.llvm.org/D125292>; even if you strip the readnone attribute > from the call instruction, we'll still treat a call to the intrinsic as > readnone. Yeah, the point here is that we used operand bundle in `D125292`. The operand bundles would break the logic you said, see: https://github.com/llvm/llvm-project/blob/3b762b3ab8d205cd6a7d42c96d39d5f4f701f2ab/llvm/include/llvm/IR/InstrTypes.h#L2315-L2325. > I think I'd prefer to lower the intrinsic as part of the codegen optimization > pipeline, not the optimization pipeline. So maybe just in in SelectionDAG? > I mean, it doesn't matter much for your planned usage in coroutines, but it's > more similar to other intrinsics, and more like what we expect it to look > like in the future. Good idea. Would do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
