yaxunl marked an inline comment as done.
yaxunl added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2555-2557
if (FeatureList.empty())
return;
assert(!FeatureList.contains(' ') && "Space in feature list");
----------------
tra wrote:
> Should we move that into the `evaluateRequiredTargetFeatures` ?
>
> `Empty feature list -> true` sounds like something that belongs to the
> evaluation logic. So does the assertion on the no-spaces assumption we make
> about the input.
>
will do when committing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125829/new/
https://reviews.llvm.org/D125829
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
