phosek added inline comments.
================
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124
set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "")
- set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "")
set(RUNTIMES_${target}_LIBCXX_ABI_VERSION 2 CACHE STRING "")
----------------
ldionne wrote:
> Note that I am removing these options here because I don't think they are
> required -- since we specify `LIBCXXABI_ENABLE_SHARED=OFF`, there is no
> shared libc++abi to link against, so we should already be linking against
> `libc++abi.a` regardless of this change.
This option was set to merge `libc++abi.a` into `libc++.a` so to achieve the
same effect, presumably we would need to set
`-DLIBCXX_CXX_ABI=libcxxabi-objects`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125683/new/
https://reviews.llvm.org/D125683
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
