beanz added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/HLSL.h:32
Action::OffloadKind DeviceOffloadKind) const override;
- std::string ComputeEffectiveClangTriple(const llvm::opt::ArgList &Args,
- types::ID InputType) const override;
+ static std::string parseTargetProfile(StringRef TargetProfile);
};
----------------
I don't like using an empty string as a sentinel for an error. Since this is no
longer overriding an existing method, we should change it. Probably the easiest
change is to llvm::Optional. Then you can return `None` in the failure cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125585/new/
https://reviews.llvm.org/D125585
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
