akyrtzi added a comment. In D125488#3510329 <https://reviews.llvm.org/D125488#3510329>, @dexonsmith wrote:
> Seems unfortunate to have a temporary regression in the commit stack, since > then you can't push incrementally (or bisect). Can the prior patch leave > behind the feature in the DependencyFilesystem, and this patch delete it now > that clang-scan-deps doesn't depend on it for performance? (Or ignore me if > I'm still not understanding...) I think creating an intermediate commit state where it's both doing lexing for tokens //and// source minimization is not worth the trouble. When committing I could merge the last 2 patches together into one commit (or all 4 of them into a commit), so there's no commit state where depscan performance is regressed. I mostly separated them like this for reviewing convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125488/new/ https://reviews.llvm.org/D125488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
