peterwaller-arm added inline comments.
================
Comment at: clang/lib/Sema/SemaExpr.cpp:10586
+ (!LHSBuiltinTy && !LHSBuiltinTy->isVLSTBuiltinType() &&
+ !LHSType->isRealType())) {
+ Diag(Loc, diag::err_typecheck_vector_not_convertable_non_scalar)
----------------
`!Ptr && [Deref Ptr]` looks suspicious. Also, if I insert an abort in this path
and run check-clang I don't see any failing tests?
It might help to name `LHSBuiltinTy && LHSBuiltinTy->isVLSTBuiltinType()`
`IsLHSVector` (likewise for RHS) or similar.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124860/new/
https://reviews.llvm.org/D124860
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
