aaron.ballman added inline comments.
================
Comment at: clang/lib/CodeGen/CGExpr.cpp:5037
if (auto builtinID = FD->getBuiltinID()) {
+ std::string AttributeNoBuiltin = "no-builtin-" + FD->getName().str();
std::string FDInlineName = (FD->getName() + ".inline").str();
----------------
Might as well use a Twine since the next line uses one as well.
================
Comment at: clang/test/CodeGen/no-builtin-2.c:38
+}
+
+// CHECK-NOT: attributes #[[NO_NOBUILTIN]] = {{{.*}}"no-builtin-memset"{{.*}}}
----------------
We should have test coverage for the wildcard form of the attribute.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124701/new/
https://reviews.llvm.org/D124701
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
