Author: Xiang Li Date: 2022-05-11T11:26:31-07:00 New Revision: 4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda
URL: https://github.com/llvm/llvm-project/commit/4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda DIFF: https://github.com/llvm/llvm-project/commit/4dae38ebfba0d8583e52c3ded8f62f5f9fa77fda.diff LOG: [HLSL] add -D option for dxc mode. Create dxc_D as alias to option D which Define <macro> to <value> (or 1 if <value> omitted). Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D125338 Added: clang/test/Driver/dxc_D.hlsl Modified: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp Removed: ################################################################################ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 05988cbbf8d7..e0eea7310fb2 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -6756,6 +6756,8 @@ def target_profile : DXCJoinedOrSeparate<"T">, MetaVarName<"<profile>">, "lib_6_3, lib_6_4, lib_6_5, lib_6_6, lib_6_7, lib_6_x," "ms_6_5, ms_6_6, ms_6_7," "as_6_5, as_6_6, as_6_7">; +def dxc_D : Option<["--", "/", "-"], "D", KIND_JOINED_OR_SEPARATE>, + Group<dxc_Group>, Flags<[DXCOption, NoXarchOption]>, Alias<D>; def emit_pristine_llvm : DXCFlag<"emit-pristine-llvm">, HelpText<"Emit pristine LLVM IR from the frontend by not running any LLVM passes at all." "Same as -S + -emit-llvm + -disable-llvm-passes.">; diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index a4777b55072b..a9fbdd4272c4 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -3471,9 +3471,9 @@ static void RenderOpenCLOptions(const ArgList &Args, ArgStringList &CmdArgs, static void RenderHLSLOptions(const ArgList &Args, ArgStringList &CmdArgs, types::ID InputType) { - const unsigned ForwardedArguments[] = {options::OPT_dxil_validator_version, - options::OPT_S, options::OPT_emit_llvm, - options::OPT_disable_llvm_passes}; + const unsigned ForwardedArguments[] = { + options::OPT_dxil_validator_version, options::OPT_D, options::OPT_S, + options::OPT_emit_llvm, options::OPT_disable_llvm_passes}; for (const auto &Arg : ForwardedArguments) if (const auto *A = Args.getLastArg(Arg)) diff --git a/clang/test/Driver/dxc_D.hlsl b/clang/test/Driver/dxc_D.hlsl new file mode 100644 index 000000000000..d32d885f11b0 --- /dev/null +++ b/clang/test/Driver/dxc_D.hlsl @@ -0,0 +1,13 @@ +// RUN: %clang_dxc -DTEST=2 -### %s 2>&1 | FileCheck %s +// RUN: %clang_dxc -DTEST=2 -Tlib_6_7 %s -fcgl -Fo - | FileCheck %s --check-prefix=ERROR + +// Make sure -D send to cc1. +// CHECK:"-D" "TEST=2" + +#ifndef TEST +#error "TEST not defined" +#elif TEST != 2 +#error "TEST defined to wrong value" +#endif + +// ERROR-NOT: error: _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits