aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a super minor nit with the test.
================ Comment at: clang/test/Driver/dxc_D.hlsl:14 +// ERROR-NOT: error: \ No newline at end of file ---------------- You should add the newline back to the end of the test file. (Feel free to do that when you land the patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
