nhaehnle requested changes to this revision.
nhaehnle added a comment.

I'm sorry to say that this patch seems confused about semantics. It lacks clear 
definitions, and in particular for the `shuffle` attribute in LLVM IR, you 
almost certainly just want the already existing `convergent` instead.

If, separately from that, you still find a need to prevent Clang from labeling 
certain function arguments or return values as `noundef`, then presumably that 
should be done with an explicit "maybe undef" attribute instead, as @jdoerfert 
suggests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125378/new/

https://reviews.llvm.org/D125378

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D125378:... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Nikita Popov via Phabricator via cfe-commits
    • [PATCH] D12... Christudasan Devadasan via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... krishna chaitanya sankisa via Phabricator via cfe-commits
    • [PATCH] D12... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits
    • [PATCH] D12... Nicolai Hähnle via Phabricator via cfe-commits
    • [PATCH] D12... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D12... Johannes Doerfert via Phabricator via cfe-commits

Reply via email to