jhuber6 added a comment.

Thanks for the review.



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:193
+  }
+  static unsigned getHashValue(const OffloadKind &Val) { return Val * 37U; }
+
----------------
tra wrote:
> Is there a particular reason for multiplying by 37? Enum values by themselves 
> should do the job just fine. 
That's what LLVM does for the regular `DenseMapInfo<uint16_t>::getHashValue()` 
so I just copied it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123810/new/

https://reviews.llvm.org/D123810

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to