linjamaki added inline comments.
================ Comment at: llvm/docs/SPIRVUsage.rst:55 + ============ ============================================================== + *<empty>* Generic SPIR-V target without any vendor-specific settings. + ============ ============================================================== ---------------- Should the explicit `unknown` string default to the generic SPIR-V too? Maybe change this to `''unknown'' or *<empty>*` here? ================ Comment at: llvm/docs/SPIRVUsage.rst:63 + ============== ============================================================ + *<empty>* Defaults to the OpenCL runtime. + ============== ============================================================ ---------------- `’’unknown’’ or *<empty>*` here too? ================ Comment at: llvm/docs/SPIRVUsage.rst:71 + ============ ============================================================== + *<empty>* Defaults to the OpenCL environment. + ============ ============================================================== ---------------- `’’unknown’’ or *<empty>*` here too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
