kbobyrev added inline comments.
================ Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); ---------------- A ================ Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:261 + ASSERT_EQ(Results.size(), 1u); + EXPECT_THAT(Results[0].Diagnostics.Includes.IgnoreHeader, + ElementsAre(val("foo"), val("bar"))); ---------------- nit: maybe `Results.front()` but up to you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits