DiggerLin marked 8 inline comments as done. DiggerLin added inline comments.
================ Comment at: clang/test/Driver/aix-ld.c:985 +// CHECK-LD64-SHARED-EXPFULL: "-bM:SRE" +// CHECK-LD64-SHARED-EXPFULL: "-bnoentry" +// CHECK-LD64-SHARED-EXPFULL: "-b64" ---------------- MaskRay wrote: > If these options are actually adjacent, check them on the same line to make > the test more strict: you can catch issues if new options are somehow > inserted in between. yes, the options are actually adjacent now, if we put these option in the same line, there maybe a failure when the driver change the options(for example adding a option) later. and it will have different style on the existing test options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
