phyBrackets updated this revision to Diff 426992. phyBrackets added a comment.
Address inline comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 Files: clang/include/clang/AST/ASTImportError.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/ASTImporterLookupTable.h clang/include/clang/AST/ASTImporterSharedState.h Index: clang/include/clang/AST/ASTImporterSharedState.h =================================================================== --- clang/include/clang/AST/ASTImporterSharedState.h +++ clang/include/clang/AST/ASTImporterSharedState.h @@ -14,6 +14,7 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERSHAREDSTATE_H #define LLVM_CLANG_AST_ASTIMPORTERSHAREDSTATE_H +#include "clang/AST/ASTImportError.h" #include "clang/AST/ASTImporterLookupTable.h" #include "clang/AST/Decl.h" #include "llvm/ADT/DenseMap.h" Index: clang/include/clang/AST/ASTImporterLookupTable.h =================================================================== --- clang/include/clang/AST/ASTImporterLookupTable.h +++ clang/include/clang/AST/ASTImporterLookupTable.h @@ -14,7 +14,6 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERLOOKUPTABLE_H #define LLVM_CLANG_AST_ASTIMPORTERLOOKUPTABLE_H -#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result #include "clang/AST/DeclarationName.h" #include "llvm/ADT/DenseMap.h" Index: clang/include/clang/AST/ASTImporter.h =================================================================== --- clang/include/clang/AST/ASTImporter.h +++ clang/include/clang/AST/ASTImporter.h @@ -14,7 +14,7 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTER_H #define LLVM_CLANG_AST_ASTIMPORTER_H -#include "clang/AST/ASTImporterLookupTable.h" +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" #include "clang/AST/DeclarationName.h" #include "clang/AST/ExprCXX.h" Index: clang/include/clang/AST/ASTImportError.h =================================================================== --- clang/include/clang/AST/ASTImportError.h +++ clang/include/clang/AST/ASTImportError.h @@ -1,4 +1,5 @@ -//===- ASTImporter.h - Import Error while Importing AST -------*- C++ -*-===// +//===- ASTImportError.h - Define errors while importing AST -------*- C++ +//-*-===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. @@ -14,7 +15,6 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERROR_H #define LLVM_CLANG_AST_ASTIMPORTERROR_H -#include "clang/AST/APValue.h" #include "llvm/Support/Error.h" namespace clang { @@ -42,10 +42,10 @@ std::string toString() const; - void log(raw_ostream &OS) const override; + void log(llvm::raw_ostream &OS) const override; std::error_code convertToErrorCode() const override; }; } // namespace clang -#endif // LLVM_CLANG_AST_ASTIMPORTERROR_H \ No newline at end of file +#endif // LLVM_CLANG_AST_ASTIMPORTERROR_H
Index: clang/include/clang/AST/ASTImporterSharedState.h =================================================================== --- clang/include/clang/AST/ASTImporterSharedState.h +++ clang/include/clang/AST/ASTImporterSharedState.h @@ -14,6 +14,7 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERSHAREDSTATE_H #define LLVM_CLANG_AST_ASTIMPORTERSHAREDSTATE_H +#include "clang/AST/ASTImportError.h" #include "clang/AST/ASTImporterLookupTable.h" #include "clang/AST/Decl.h" #include "llvm/ADT/DenseMap.h" Index: clang/include/clang/AST/ASTImporterLookupTable.h =================================================================== --- clang/include/clang/AST/ASTImporterLookupTable.h +++ clang/include/clang/AST/ASTImporterLookupTable.h @@ -14,7 +14,6 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERLOOKUPTABLE_H #define LLVM_CLANG_AST_ASTIMPORTERLOOKUPTABLE_H -#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result #include "clang/AST/DeclarationName.h" #include "llvm/ADT/DenseMap.h" Index: clang/include/clang/AST/ASTImporter.h =================================================================== --- clang/include/clang/AST/ASTImporter.h +++ clang/include/clang/AST/ASTImporter.h @@ -14,7 +14,7 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTER_H #define LLVM_CLANG_AST_ASTIMPORTER_H -#include "clang/AST/ASTImporterLookupTable.h" +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" #include "clang/AST/DeclarationName.h" #include "clang/AST/ExprCXX.h" Index: clang/include/clang/AST/ASTImportError.h =================================================================== --- clang/include/clang/AST/ASTImportError.h +++ clang/include/clang/AST/ASTImportError.h @@ -1,4 +1,5 @@ -//===- ASTImporter.h - Import Error while Importing AST -------*- C++ -*-===// +//===- ASTImportError.h - Define errors while importing AST -------*- C++ +//-*-===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. @@ -14,7 +15,6 @@ #ifndef LLVM_CLANG_AST_ASTIMPORTERROR_H #define LLVM_CLANG_AST_ASTIMPORTERROR_H -#include "clang/AST/APValue.h" #include "llvm/Support/Error.h" namespace clang { @@ -42,10 +42,10 @@ std::string toString() const; - void log(raw_ostream &OS) const override; + void log(llvm::raw_ostream &OS) const override; std::error_code convertToErrorCode() const override; }; } // namespace clang -#endif // LLVM_CLANG_AST_ASTIMPORTERROR_H \ No newline at end of file +#endif // LLVM_CLANG_AST_ASTIMPORTERROR_H
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
