vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land.
LGTM, with one nit. ================ Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple %itanium_abi_triple | FileCheck %s +// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple x86_64-apple-macosx10.9 | FileCheck %s ---------------- I don't really understand the significance of `makeItaniumABITriple`. Could you explain why this change is necessary? If it's not, please drop it. Repository: rL LLVM http://reviews.llvm.org/D21741 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
