owenpan added a comment. In D121370#3489245 <https://reviews.llvm.org/D121370#3489245>, @krasimir wrote:
> In D121370#3488401 <https://reviews.llvm.org/D121370#3488401>, @kwk wrote: > >> @krasimir could you please test this patch on your side? > > @kwk thank you! the new version of the patch looks good! > > I didn't know before about the issue you found with the `/* a comment before > */ #include <foo>` (and since it's preexisting, if it's tricky to address, it > would be reasonable to just file a bug for it and omit fixing it by this > work, I think). +1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
