tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/AST/ASTContext.cpp:11770-11778
+ if (!LangOpts.CUDA || LangOpts.CUDAIsDevice) {
+ assert(!ForAuxTarget && "Only CUDA/HIP host compilation supports mangling "
+ "number for aux target");
return Res;
+ }
// CUDA/HIP host compilation encodes host and device mangling numbers
----------------
Nit: I'd rephrase it as :
```
if (LangOpts.CUDA && !LangOpts.CUDAIsDevice) {
Res = ForAuxTarget ? Res >> 16 : Res & 0xFFFF;
} else {
assert(!ForAuxTarget && "Only CUDA/HIP host compilation supports mangling
number for aux target");
}
return Res > 1 ? Res : 1;
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124842/new/
https://reviews.llvm.org/D124842
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
