MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:171
   check_symbol_exists(__ve__ "" __VE)
+  check_symbol_exists(__AVR__ "" __AVR)
   if(__ARM)
----------------
Keep the list in alphabetical order. Move avr to the beginning. Ignore some 
entries which are unordered.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:216
     add_default_target_arch(ve)
+  elseif(__AVR)
+    add_default_target_arch(avr)
----------------
Keep the list in alphabetical order. Move avr to the beginning. Ignore some 
entries which are unordered.


================
Comment at: compiler-rt/cmake/builtin-config-ix.cmake:55
 set(VE ve)
+set(AVR avr)
 
----------------
Keep the list in alphabetical order. Move avr to the beginning. Ignore some 
entries which are unordered.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:671
 
+set(avr_SOURCES
+  avr/mulqi3.S
----------------
Keep the `*_SOURCES` in alphabetical order. Move avr to the beginning. Ignore 
some entries which are unordered.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123200/new/

https://reviews.llvm.org/D123200

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to