rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land.
In D124700#3483715 <https://reviews.llvm.org/D124700#3483715>, @kerbowa wrote: > In D124700#3483633 <https://reviews.llvm.org/D124700#3483633>, @rampitec > wrote: > >> In D124700#3483609 <https://reviews.llvm.org/D124700#3483609>, @kerbowa >> wrote: >> >>> In D124700#3483556 <https://reviews.llvm.org/D124700#3483556>, @rampitec >>> wrote: >>> >>>> You do not handle masks other than 0 yet? >>> >>> We handle 0 and 1 only. >> >> Do you mean 1 is supported simply because it has side effects? If I >> understand it right you will need to remove this to support more flexible >> masks, right? > > Yes. LGTM given that. But change imm to i32 before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
