nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

In D119296#3481573 <https://reviews.llvm.org/D119296#3481573>, @joaomoreira 
wrote:

> I'm not an expert on LLVM's pipeline, but it just feels a little awkward and 
> redundant that we need passes to fix what other passes messed up regarding a 
> pass that executed before everything.

I don't think so. Consider DCE; other passes leave behind garbage all the time; 
DCE is expected to clean up after them.

New changes LGTM.

Any chance we can get a test that debug info is correctly attributed to the use 
of the builtin?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to