smeenai added a comment.

In D124563#3478623 <https://reviews.llvm.org/D124563#3478623>, @aaronpuchert 
wrote:

> So maybe we should simply remove
>
>   # These test input files rely on two-byte Windows (CRLF) line endings.
>   clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf
>   clang-apply-replacements/Inputs/crlf/crlf.cpp.expected text eol=crlf
>
> from the `.gitattributes` file again. Then we can keep them stored with CRLF 
> endings, and each file has a comment anyway that they rely on them. The files 
> have been there for many years and never been a problem.

I *think* this would mean that if you're on Windows and have `core.autocrlf` 
set to `input`, when you commit changes to this files, Git will convert them 
back to LF line endings. Not 100% sure of that though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124563/new/

https://reviews.llvm.org/D124563

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to