dblaikie added subscribers: aaron.ballman, rsmith. dblaikie added a comment.
@rsmith @aaron.ballman - might be especially interesting to know your thoughts on the C++ chapter-based testing and what the intent there is as clang changes default versions/new versions are added. (& also whether there's an approach (like moving the default language into the driver) that'd be worthwhile to lower the maintenance cost of these sort of migrations without compromising on test coverage/ending up with all the test coverage testing previous versions of the language and not what everyone's using in the wild) ================ Comment at: clang/test/CXX/class.access/class.friend/p1.cpp:4 // RUN: %clang_cc1 -fsyntax-only -verify -std=c++14 %s -// RUN: %clang_cc1 -fsyntax-only -verify %s ---------------- Might be worth knowing the version history of tests like this? (in here and other test files) - perhaps the intent is for this test to check the code is valid in all language versions & so should grow more explicit version lines as the language evolves? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124434/new/ https://reviews.llvm.org/D124434 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
