erichkeane added a comment.

I found



================
Comment at: clang/test/SemaTemplate/concepts.cpp:386-388
+  []()
+    requires(constraint<decltype(Local)>)
+  {}();
----------------
erichkeane wrote:
> ChuanqiXu wrote:
> > We might need more negative tests.
> > Now it would pass even if I write:
> > ```
> > []()
> >     requires(false)
> > {}();
> > ```
> Ouch!  I'll have to see if I can find where we're missing that check!
Well, I fixed most of the OTHER stuff I think by setting up the context 
properly (see incoming patch!), but this ends up failing crashing, as does a 
few other things in this test.  Still looking through it, but want to get you 
the latest.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119544/new/

https://reviews.llvm.org/D119544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to