hokein added a comment.

In D124384#3471917 <https://reviews.llvm.org/D124384#3471917>, @sammccall wrote:
> This is a reasonable immediate fix, but creating null-typed expressions that 
> live *outside* the recoveryexpr seems scary, and likely to violate expected 
> invariants elsewhere too...

Yeah, the fundamental issue is that we create a null-typed expression 
(`ParenListExpr`) outside a template context, which is similar to our prior 
case where we have a dependent expression outside a template context. Perhaps 
it violates invariants in other places as well, but this is the first time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124384/new/

https://reviews.llvm.org/D124384

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D124384: [clang] Fix a ... Haojian Wu via Phabricator via cfe-commits

Reply via email to