Re: [PATCH] D21601: Make tooling::applyAllReplacements return llvm::Expected instead of empty string to indicate potential error.

[Eric Liu via cfe-commits]

Would EXPECTED_FALSE(!Code) be better?

On Fri, Jun 24, 2016, 17:42 Manuel Klimek <kli...@google.com> wrote:

> klimek added inline comments.
>
> ================
> Comment at: unittests/Format/CleanupTest.cpp:258
> @@ +257,3 @@
> +    auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style);
> +    EXPECT_TRUE((bool)CleanReplaces)
> +        << llvm::toString(CleanReplaces.takeError()) << "\n";
> ----------------
> Hm. Can we make it work with EXPECT_TRUE somehow?
>
>
> http://reviews.llvm.org/D21601
>
>
>
>

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits