benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land.
Minor suggestion for the test case, but otherwise LGTM. ================ Comment at: clang/test/Index/using_if_exists.cpp:9 +// CHECK: [[@LINE-1]]:11 | using/C++ | foo | c:@UD@foo | <no-cgname> | Decl | rel: 0 +// CHECK-NOT: [[@LINE-2]]:11 | <unknown> ---------------- Could we drop the `[[@LINE-2]]:11 |` part of the CHECK-NOT to make it a bit more robust? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124288/new/ https://reviews.llvm.org/D124288 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
